Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-worker-debug #28307

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-worker-debug #28307

wants to merge 1 commit into from

Commits on Jun 19, 2019

  1. test: fix flaky test-worker-debug 

    Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

Fixes: nodejs#28299
Fixes: nodejs#28106
    @addaleax
    addaleax committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    441fc92 View commit details
    Browse the repository at this point in the history