Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: extend workaround for MSVC optimizer bug #28286

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

targos
Copy link
Member

@targos targos commented Jun 19, 2019

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Jun 19, 2019
@targos targos requested a review from refack June 19, 2019 07:11
@targos
Copy link
Member Author

targos commented Jun 19, 2019

I would like to fast-track this because this issue is blocking the release of v12.5.0.

Please 👍 this comment if you agree.

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 19, 2019
@targos targos mentioned this pull request Jun 19, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 19, 2019

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@richardlau
Copy link
Member

I would like to fast-track this because this issue is blocking the release of v12.5.0.

Please 👍 this comment if you agree.

Not objecting to this PR but the referenced url (https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html) seems to reference VS2019 while the failing link for 12.5.0 is VS2017: https://ci.nodejs.org/job/node-compile-windows/27287/label=win-vs2017/. The error also doesn't look the same:

10:35:50   c:\workspace\node-compile-windows\deps\v8\include\v8-platform.h(381): note: see declaration of 'v8::Platform::CallDelayedOnForegroundThread'
10:36:20   [4932] Failed to execute script clcache_main
10:36:20   Traceback (most recent call last):
10:36:20     File "clcache_main.py", line 2, in <module>
10:36:20     File "clcache\__main__.py", line 1666, in main
10:36:20     File "clcache\__main__.py", line 1693, in processCompileRequest
10:36:20     File "clcache\__main__.py", line 1751, in scheduleJobs
10:36:20     File "clcache\__main__.py", line 1479, in cleanCache
10:36:20     File "contextlib.py", line 112, in __enter__
10:36:20     File "clcache\__main__.py", line 558, in lock
10:36:20     File "contextlib.py", line 112, in __enter__
10:36:20     File "clcache\__main__.py", line 221, in allSectionsLocked
10:36:20     File "clcache\__main__.py", line 370, in acquire
10:36:20   clcache.__main__.CacheLockException: Failed to acquire lock Local\C--Users-Administrator-clcache-manifests-00 after 30000ms; try setting CLCACHE_OBJECT_CACHE_TIMEOUT_MS environment variable to a larger value.
10:36:20 C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(314,5): error MSB6006: "cl.exe" exited with code -1. [c:\workspace\node-compile-windows\cctest.vcxproj]

@refack
Copy link
Contributor

refack commented Jun 19, 2019

seems to reference VS2019 while the failing link for 12.5.0 is VS2017

It seems like the same issue is triggering timeouts with MSVS2017 as well.
The errors look different because we've set clcache to timeout before Jenkins, and we have two MSBuild jobs racing for a shared lock so where the actual timeout happens can be non-deterministic.

@refack refack added the windows Issues and PRs related to the Windows platform. label Jun 19, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 19, 2019

Builds are starting to fail in CI with V8 7.5 and 7.6.

Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs#28286
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack refack merged commit 05b8526 into nodejs:master Jun 19, 2019
targos added a commit that referenced this pull request Jun 20, 2019
Builds are starting to fail in CI with V8 7.5 and 7.6.

Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: #28286
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos deleted the fix-msvc branch October 17, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. v8 engine Issues and PRs related to the V8 dependency. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants