Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove instructions to post CI links #28248

Merged
merged 0 commits into from
Jun 18, 2019
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 16, 2019

Remove instructions (in the Collaborator Guide) to post CI links. The
bot does that now.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott Trott added the doc Issues and PRs related to the documentations. label Jun 16, 2019
@nodejs-github-bot

This comment has been minimized.

@Trott
Copy link
Member Author

Trott commented Jun 16, 2019

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 17, 2019
@Trott
Copy link
Member Author

Trott commented Jun 18, 2019

Landed in 8030ca5

@Trott Trott closed this Jun 18, 2019
@Trott Trott deleted the post-a-ci branch June 18, 2019 16:36
@Trott Trott merged commit 8030ca5 into nodejs:master Jun 18, 2019
targos pushed a commit that referenced this pull request Jul 2, 2019
Remove instructions (in the Collaborator Guide) to post CI links. The
bot does that now.

PR-URL: #28248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants