Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for Http2Stream#id property #28074

Closed
wants to merge 3 commits into from
Closed

Add documentation for Http2Stream#id property #28074

wants to merge 3 commits into from

Conversation

murgatroid99
Copy link
Contributor

Checklist
  • documentation is changed or added

This property is already mentioned in this section of the documentation. The implementation can be found here, and it was introduced in the original commit for the http2 module

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Jun 5, 2019
lpinca
lpinca approved these changes Jun 5, 2019
View reviewed changes
doc/api/http2.md Outdated Show resolved Hide resolved
@murgatroid99 @lpinca
Use code markup for the word undefined
507111b 
Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>
Trott
Trott reviewed Jun 6, 2019
View reviewed changes
doc/api/http2.md Outdated Show resolved Hide resolved
@murgatroid99 @Trott
Explicitly include undefined in type specifier
4ba370f 
Co-Authored-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Jun 10, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3668/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 10, 2019
@cjihrig
Copy link
Contributor

cjihrig commented Jun 11, 2019

Landed in 155caf7. Thanks!

@cjihrig cjihrig closed this Jun 11, 2019
cjihrig pushed a commit that referenced this pull request Jun 11, 2019
@murgatroid99 @cjihrig
doc: document Http2Stream#id property
155caf7 
PR-URL: #28074
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@murgatroid99 @BridgeAR
doc: document Http2Stream#id property
360c708 
PR-URL: #28074
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@murgatroid99 @Trott @cjihrig @jasnell @addaleax @lpinca @trivikr @nodejs-github-bot