Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completed secure-pair performance test with clear connections #27971

Closed
wants to merge 2 commits into from

Conversation

tufosa
Copy link

@tufosa tufosa commented May 30, 2019

A very simple patch to the existing secure-pair benchmark in order to include clear connections in the test and expose this issue

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

adds clear connections to the secure-pair performance test to prove
thah in some cases (when the sender send the data in small chunks)
clear connections perform worse than TLS connections

Refs: nodejs#27970
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. tls Issues and PRs related to the tls subsystem. labels May 30, 2019
@addaleax
Copy link
Member

@tufosa Does it make sense to add a smaller chunk size to benchmark/net/net-pipe.js?

@tufosa
Copy link
Author

tufosa commented May 30, 2019

@addaleax yep!! Didn't know about this benchmark. Done in 809ee8c. The test with chunks of 2 bytes performs 100 times worse than the 64 bytes one.

@tufosa
Copy link
Author

tufosa commented Jul 17, 2019

@addaleax it's my first PR to this project and I am not sure how can we move this forward. Everything seems OK, but I don't know if I need to do anything else in order to get this reviewed and eventually approved. Can you help me with this?

@gireeshpunathil
Copy link
Member

ping @addaleax

@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gireeshpunathil Anything in particular I’d need to be aware of here?

@gireeshpunathil
Copy link
Member

@addaleax - no, I pinged because I see this PR not moving and saw you as the only person engaged on this PR so far; so!

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

gireeshpunathil pushed a commit that referenced this pull request Dec 20, 2019
adds clear connections to the secure-pair performance test to prove
that in some cases (when the sender send the data in small chunks)
clear connections perform worse than TLS connections

Also add a byte chunk size test to benchmark/net/net-pipe.js

Refs: #27970

PR-URL: #27971
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@gireeshpunathil
Copy link
Member

landed in fc553fd thanks for the contribution!

BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
adds clear connections to the secure-pair performance test to prove
that in some cases (when the sender send the data in small chunks)
clear connections perform worse than TLS connections

Also add a byte chunk size test to benchmark/net/net-pipe.js

Refs: #27970

PR-URL: #27971
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos pushed a commit that referenced this pull request Jan 14, 2020
adds clear connections to the secure-pair performance test to prove
that in some cases (when the sender send the data in small chunks)
clear connections perform worse than TLS connections

Also add a byte chunk size test to benchmark/net/net-pipe.js

Refs: #27970

PR-URL: #27971
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
adds clear connections to the secure-pair performance test to prove
that in some cases (when the sender send the data in small chunks)
clear connections perform worse than TLS connections

Also add a byte chunk size test to benchmark/net/net-pipe.js

Refs: #27970

PR-URL: #27971
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants