Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying that an error will be raised when there is a directory at newPath #27963

Closed

Conversation

andyalcantara
Copy link

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 30, 2019
doc/api/fs.md Outdated Show resolved Hide resolved
doc/api/fs.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented May 30, 2019

Welcome @andyalcantara, and thanks for the pull request! Looks good to me with a small modification.

Co-Authored-By: Rich Trott <rtrott@gmail.com>
@Trott

This comment has been minimized.

@Trott
Copy link
Member

Trott commented Jun 1, 2019

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 2, 2019
Trott added a commit to Trott/io.js that referenced this pull request Jun 2, 2019
PR-URL: nodejs#27963
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@Trott
Copy link
Member

Trott commented Jun 2, 2019

Landed in e7ca398

@Trott Trott closed this Jun 2, 2019
@Trott
Copy link
Member

Trott commented Jun 2, 2019

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

targos pushed a commit that referenced this pull request Jun 3, 2019
PR-URL: #27963
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targos targos mentioned this pull request Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants