Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: move exports to bottom for better code style #27845

Closed
wants to merge 1 commit into from
Closed

child_process: move exports to bottom for better code style #27845

wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

@himself65 himself65 commented May 24, 2019 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the child_process Issues and PRs related to the child_process subsystem. label May 24, 2019
@himself65 himself65 marked this pull request as ready for review May 24, 2019 06:09
mscdex
mscdex reviewed May 24, 2019
View reviewed changes
lib/child_process.js Outdated Show resolved Hide resolved
jasnell
jasnell reviewed May 24, 2019
View reviewed changes
lib/child_process.js Outdated Show resolved Hide resolved
@jasnell jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 24, 2019
@himself65 himself65 force-pushed the 27639 branch 2 times, most recently from fe39082 to 897ca32 Compare May 25, 2019 03:58
@targos targos removed the semver-major PRs that contain breaking changes and should be released in the next major version. label May 25, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23322/

@himself65 himself65 force-pushed the 27639 branch 2 times, most recently from be8b3cb to 6780a11 Compare May 25, 2019 17:42
@BridgeAR
Copy link
Member

@himself65 it seems like this needs a rebase :)

@himself65
Copy link
Member Author

@BridgeAR thanks. rebased

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23557/

@Trott
Copy link
Member

Trott commented Jun 2, 2019

Landed in aa00968

@Trott Trott closed this Jun 2, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 2, 2019
@himself65 @Trott
child_process: move exports to bottom for consistent code style
aa00968 
PR-URL: nodejs#27845
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@himself65 himself65 deleted the 27639 branch June 2, 2019 13:50
targos pushed a commit that referenced this pull request Jun 3, 2019
@himself65 @targos
child_process: move exports to bottom for consistent code style
ea2d550 
PR-URL: #27845
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targos targos mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex mscdex left review comments

@jasnell jasnell jasnell left review comments

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@himself65 @nodejs-github-bot @BridgeAR @Trott @mscdex @jasnell @targos @ZYSzys