Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-https-agent-additional-options #27830

Closed
wants to merge 4 commits into from

Commits on May 22, 2019

  1. test: replace flag with option

    test-https-agent-additional-options is invoked with a command-line flag.
    However, there is an equivalent option that can be enabled within the
    code. Do that instead.
    Trott committed May 22, 2019
    Configuration menu
    Copy the full SHA
    81e8971 View commit details
    Browse the repository at this point in the history
  2. test: favor arrow functions for anonymous callbacks

    In test-https-agent-additional-options, use arrow functions for
    anonymous callbacks. Replace a use of `this` with the relevant constant.
    Trott committed May 22, 2019
    Configuration menu
    Copy the full SHA
    9181f38 View commit details
    Browse the repository at this point in the history
  3. test: refactor test-https-agent-additional-options

    Move callback to location where it is less confusing.
    Trott committed May 22, 2019
    Configuration menu
    Copy the full SHA
    212ecda View commit details
    Browse the repository at this point in the history

Commits on May 23, 2019

  1. test: fix test-https-agent-additional-options

    test-https-agent-additional-options can occasionally fail if a socket
    closes before the checks near the end of the test. Modify the test to
    check the freeSockets pool after each request.
    
    Fixes: nodejs#24449
    Trott committed May 23, 2019
    Configuration menu
    Copy the full SHA
    83f77d2 View commit details
    Browse the repository at this point in the history