Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix segfault handling/RegisterSignalHandler #27775

Closed
wants to merge 4 commits into from
Closed

src: fix segfault handling/RegisterSignalHandler #27775

wants to merge 4 commits into from

Commits on Jun 14, 2019

  1. src: do not use posix feature macro in node.h 

    This macro is only defined when building Node.js, so addons cannot
use it as a way of detecting feature availability.
    @addaleax
    addaleax committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    97ea9f0 View commit details
    Browse the repository at this point in the history

  2. src: reset SIGSEGV handler before crashing 

    Without this, we would re-enter the signal handler immediately
after re-raising the signal, leading to an infinite loop.
    @addaleax
    addaleax committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    543b838 View commit details
    Browse the repository at this point in the history

  3. src: forbid reset_handler for SIGSEGV handling 

    This is not easily implementable, and should be explicitly disallowed.
    @addaleax
    addaleax committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    cdd38f4 View commit details
    Browse the repository at this point in the history

  4. test: add addon tests for RegisterSignalHandler() 

    Ensure coverage for the different combinations of arguments.
    @addaleax
    addaleax committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    5dd1210 View commit details
    Browse the repository at this point in the history