Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build,win: create junction instead of symlink to out\%config% #27736

Merged
merged 1 commit into from
May 25, 2019

Conversation

refack
Copy link
Contributor

@refack refack commented May 16, 2019

Refs: #27149 (comment)

Create a junction to out\%config% instead of symlink, because symlinks need elevation or developer mode on Win10.

Background: https://blogs.windows.com/buildingapps/2016/12/02/symlinks-windows-10/
H/T @yodurr

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels May 16, 2019
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@refack
Copy link
Contributor Author

refack commented May 16, 2019

/CC @nodejs/build-files @nodejs/platform-windows

vcbuild.bat Outdated Show resolved Hide resolved
@refack refack self-assigned this May 18, 2019
vcbuild.bat Outdated Show resolved Hide resolved
PR-URL: nodejs#27736
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@refack refack merged commit a388f4d into nodejs:master May 25, 2019
@refack refack deleted the mklink-j-instead-of-d branch May 25, 2019 18:44
@refack refack removed their assignment May 25, 2019
targos pushed a commit that referenced this pull request May 28, 2019
PR-URL: #27736
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@targos targos mentioned this pull request Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants