Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: allow RegExp in required-modules eslint rule #27647

Merged
merged 1 commit into from
May 13, 2019
Merged

tools: allow RegExp in required-modules eslint rule #27647

merged 1 commit into from
May 13, 2019

Conversation

richardlau
Copy link
Member

Refs: #27545 (review)

The fixup commit is to tidy up the error message when the lint rule fails (kept
separate here for ease of reviewing) and should be autosquashed on landing.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3484

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 11, 2019
@richardlau richardlau mentioned this pull request May 11, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23048/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2019
@richardlau richardlau force-pushed the eslint-required-modules-regexp branch from 3e6983a to 45a4230 Compare May 13, 2019 19:01
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23091/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23094/

@richardlau
tools: allow RegExp in required-modules eslint rule
1df3080 
PR-URL: nodejs#27647
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@richardlau richardlau force-pushed the eslint-required-modules-regexp branch from 45a4230 to 1df3080 Compare May 13, 2019 20:08
@richardlau
Copy link
Member Author

Landed in 1df3080.

@richardlau richardlau merged commit 1df3080 into nodejs:master May 13, 2019
targos pushed a commit that referenced this pull request May 14, 2019
@richardlau @targos
tools: allow RegExp in required-modules eslint rule
1365683 
PR-URL: #27647
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@richardlau @nodejs-github-bot @Trott @targos @BridgeAR