Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: code cleanup #27591

Merged
merged 0 commits into from
May 9, 2019
Merged

inspector: code cleanup #27591

merged 0 commits into from
May 9, 2019

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented May 6, 2019

  1. Do not rely on a string comparison to identify when
    the frontend is ready to run and override a callback instead.
  2. Remove unused boolean flag.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3449

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol labels May 6, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22989/

alexkozy
alexkozy approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@alexkozy alexkozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 7, 2019
@eugeneo eugeneo closed this May 9, 2019
@eugeneo eugeneo merged commit 5e064f3 into nodejs:master May 9, 2019
@eugeneo eugeneo deleted the use-callback-dont-parse branch May 9, 2019 19:00
@eugeneo
Copy link
Contributor Author

eugeneo commented May 9, 2019

Thank you for the review. PR landed as https://github.com/eugeneo/node/commit/5e064f3672b56fff29f9bf6c75fbe060b86554a5

targos pushed a commit that referenced this pull request May 10, 2019
@targos
inspector: code cleanup
d2d3bf8 
1. Do not rely on a string comparison to identify when
   the frontend is ready to run and override a callback instead.
2. Remove unused boolean flag.

PR-URL: #27591
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkozy alexkozy alexkozy approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eugeneo @nodejs-github-bot @alexkozy @addaleax