Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: refactor deprecated UVException usage in pipe-wrap.cc #27562

Closed
wants to merge 1 commit into from
Closed

src: refactor deprecated UVException usage in pipe-wrap.cc #27562

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. net Issues and PRs related to the net subsystem. labels May 4, 2019
gengjiawen
gengjiawen commented May 4, 2019
View reviewed changes
src/node.h Outdated Show resolved Hide resolved
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 5, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22961/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22977/

@gengjiawen
Copy link
Member Author

gengjiawen commented May 9, 2019 •
edited
Loading

@danbev @ZYSzys Can you rerun the failed one in this PR and #27512, thanks.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23010/

@gengjiawen
Copy link
Member Author

@ZYSzys Looks like this one still failed.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23012/

@antsmartian
Copy link
Contributor

antsmartian commented May 9, 2019 •
edited
Loading

Triggered a re-run (resume).

@gengjiawen
Copy link
Member Author

test-http2-client-destroy failed due to #20750.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23024/

@ZYSzys
Copy link
Member

ZYSzys commented May 10, 2019

Landed in 07e0395 🎉

@ZYSzys ZYSzys closed this May 10, 2019
ZYSzys pushed a commit that referenced this pull request May 10, 2019
@gengjiawen @ZYSzys
src: refactor deprecated UVException usage in pipe-wrap.cc
07e0395 
PR-URL: #27562
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request May 10, 2019
@gengjiawen @targos
src: refactor deprecated UVException usage in pipe-wrap.cc
62fe342 
PR-URL: #27562
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@antsmartian antsmartian antsmartian approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gengjiawen @nodejs-github-bot @antsmartian @ZYSzys @Trott @addaleax @cjihrig