test: refactor test-tls-enable-trace-cli.js

[cjihrig]

This test appears to be flakey on Unix. I'm not entirely sure why, but I think it may be related to the additional piping of the child process stderr (although this test is mostly a copy of another test that isn't exhibiting problems). This commit simplifies the test a bit.

Some preliminary testing seems promising:

• node-test-commit: https://ci.nodejs.org/job/node-test-commit/28351/
• Re-run on Linux, even though no failures were seen on the previous run: https://ci.nodejs.org/job/node-test-commit-linux/27396/
• Stress test: https://ci.nodejs.org/job/node-stress-single-test/2205/

If the stress test comes back green, I'd recommend fast tracking this.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[nodejs-github-bot]

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3434

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22928/

[sam-github]

Its possible that pumping some data through the connections before the cleanup() would fix this, perhaps the connection is closing too early, which is a common source of races. The server side is piping the req to the rsp, so the client could just do something like const c = pair.client.conn; c.end('x'); c.on('end', cleanup); instead of the return cleanup().

[cjihrig]

The following error is happening in the child process:

AssertionError [ERR_ASSERTION]: ifError got unwanted exception: 140480012626824:error:09072007:PEM routines:PEM_write_bio:BUF lib:../deps/openssl/openssl/crypto/pem/pem_lib.c:658:
140480012626824:error:09072007:PEM routines:PEM_write_bio:BUF lib:../deps/openssl/openssl/crypto/pem/pem_lib.c:658:

[sam-github]

Most of the ways that can happen look like BIO_write() not writing everything it was asked to, and it might have registered an error when it failed. Printing the err.opensslErrorStack might give some more info here.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22980/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22997/ (✔️)

[danbev]

Landed in 9a174db.