Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention fs.mkdir's behavior with existing directories in docs. #27505

Closed
wants to merge 3 commits into from
Closed

Mention fs.mkdir's behavior with existing directories in docs. #27505

wants to merge 3 commits into from

Conversation

Gaelan
Copy link
Contributor

@Gaelan Gaelan commented Apr 30, 2019

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Apr 30, 2019
richardlau
richardlau reviewed Apr 30, 2019
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
doc/api/fs.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Apr 30, 2019
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Apr 30, 2019
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
Trott and others added 2 commits April 30, 2019 16:47
@Trott
Copy link
Member

Trott commented May 1, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3411/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 14, 2019
@Trott
Copy link
Member

Trott commented May 19, 2019 •
edited
Loading

Landed in 13d2df5

@Trott Trott closed this May 19, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request May 19, 2019
@Gaelan @Trott
doc: clarify behavior of fs.mkdir
13d2df5 
PR-URL: nodejs#27505
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented May 19, 2019

Thanks for the contribution! 🎉

targos pushed a commit that referenced this pull request May 20, 2019
@Gaelan @targos
doc: clarify behavior of fs.mkdir
1f7a527 
PR-URL: #27505
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau left review comments

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gaelan @Trott @jasnell @richardlau @nodejs-github-bot