Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add mustCall to test-dgram-connect-send-callback-buffer #27466

Closed
wants to merge 1 commit into from
Closed

test: add mustCall to test-dgram-connect-send-callback-buffer #27466

wants to merge 1 commit into from

Conversation

shenchenxh
Copy link

@shenchenxh shenchenxh commented Apr 28, 2019 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 28, 2019
@ZYSzys ZYSzys added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Apr 28, 2019
@gireeshpunathil
Copy link
Member

please leave 👍 to fast track

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22773/

@oyyd oyyd added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 28, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22786/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22791/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22795/

@oyyd
Copy link
Contributor

oyyd commented Apr 29, 2019

The CI is actually green now: https://ci.nodejs.org/job/node-test-pull-request/22795/

(The test node-test-linux-linked-zlib seems to be removed now?)

oyyd pushed a commit that referenced this pull request Apr 29, 2019
@oyyd
test: add mustCall to test-dgram-connect-send-callback-buffer
77b9007 
PR-URL: #27466
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
@oyyd
Copy link
Contributor

oyyd commented Apr 29, 2019

Landed in 77b9007, thanks!

You can visit https://www.nodetodo.org/next-steps/ for more ideas to contribute.

@oyyd oyyd closed this Apr 29, 2019
targos pushed a commit that referenced this pull request Apr 29, 2019
@targos
test: add mustCall to test-dgram-connect-send-callback-buffer
23fb430 
PR-URL: #27466
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@oyyd oyyd oyyd approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shenchenxh @gireeshpunathil @nodejs-github-bot @oyyd @cjihrig @ZYSzys