src: move SIGINT watchdog utils to the contextify binding #27290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are used when evaluating scripts so it makes more sense to put them in the contextify binding whose other methods are going to be used together.
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
c++
This comment has been minimized.
This comment has been minimized.
danbev
approved these changes
Apr 18, 2019
This comment has been minimized.
This comment has been minimized.
ZYSzys
approved these changes
Apr 18, 2019
ZYSzys
added
the
author ready
BridgeAR
approved these changes
Apr 18, 2019
jasnell
approved these changes
Apr 20, 2019
joyeecheung
added a commit
that referenced
this pull request
Apr 22, 2019
These are used when evaluating scripts so it makes more sense to put them in the contextify binding whose other methods are going to be used together. PR-URL: #27290 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 19e3e02 |
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are used when evaluating scripts so it makes more sense
to put them in the contextify binding whose other methods are
going to be used together.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes