Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove require('util') from lib/vm/source_text_module.js #27285

Closed
wants to merge 1 commit into from
Closed

lib: remove require('util') from lib/vm/source_text_module.js #27285

wants to merge 1 commit into from

Conversation

dozingpip
Copy link

Remove usage of require('util').types and require('util').inspect.
Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the vm Issues and PRs related to the vm subsystem. label Apr 17, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22537/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22544/

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 18, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Apr 21, 2019

Landed in e9fb92d.

Congratulations for your first contribution to Node.js core 🎉.

@ZYSzys ZYSzys closed this Apr 21, 2019
ZYSzys pushed a commit that referenced this pull request Apr 21, 2019
@ZYSzys
vm: remove require('util') from lib/vm/source_text_module.js
e9fb92d 
PR-URL: #27285
Refs: #26546
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@dozingpip dozingpip deleted the util-internal-source-text-module branch April 28, 2019 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dozingpip @nodejs-github-bot @ZYSzys @joyeecheung