Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: travis: start slower jobs first #27205

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Conversation

refack
Copy link
Contributor

@refack refack commented Apr 12, 2019

even though jobs can run in parallel they start in declaration order

/CC @nodejs/build-files @nodejs/testing

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 12, 2019
@richardlau
Copy link
Member

One thing I have noticed is that the way staging works if any of the first stage jobs fail (e.g. commit message lint or linter) then the second stage isn't run (i.e. no tests are run). On the one hand having the linting done in the first stage returns results quicker, but maybe we can move linting into the test stage so all linting and tests are attempted (assuming the code compiles)?

@refack
Copy link
Contributor Author

refack commented Apr 12, 2019

move linting into the test stage

So that compiles >> no lint, makes sense

Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: when squashing please reword the first commit (something like "run compilation jobs first").

@refack refack self-assigned this Apr 13, 2019
even though jobs can run in parallel they start in declaration order

* this patch makes "compiles >> no lint" in terms of precedence

PR-URL: nodejs#27205
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@refack refack merged commit f3b5cc0 into nodejs:master Apr 15, 2019
@refack refack deleted the silly-travis-trick branch April 15, 2019 22:55
@refack
Copy link
Contributor Author

refack commented Apr 15, 2019

Pre:
image
Post:
image

🤘 🎸 👨‍🎤

[Update] even better:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants