Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools,doc: fix 404 broken links in docs #27168

Closed
wants to merge 3 commits into from
Closed

tools,doc: fix 404 broken links in docs #27168

wants to merge 3 commits into from

Conversation

07Gond
Copy link
Contributor

@07Gond 07Gond commented Apr 10, 2019 •
edited
Loading

Change the linkManPages function to catch the uname and curl correct websites on the docs page.

Fixes: #26074

image

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@07Gond
tools,doc: fix 404 broken links in docs
eecc04c 
Change the linkManPages function to catch the uname and curl
correct websites on the docs page.

Fixes: nodejs#26074
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Apr 10, 2019
vsemozhetbyt
vsemozhetbyt reviewed Apr 10, 2019
View reviewed changes
tools/doc/html.js Outdated Show resolved Hide resolved
BridgeAR
BridgeAR approved these changes Apr 16, 2019
View reviewed changes
tools/doc/html.js Outdated Show resolved Hide resolved
tools/doc/html.js Outdated Show resolved Hide resolved
@gengjiawen
Copy link
Member

In the long run we should add tools to prevent this ?
I wonder can https://github.com/JustinBeckwith/linkinator integrate to travis-ci ? (Suggested by @bnb )
cc @richardlau @Trott

@richardlau richardlau mentioned this pull request Apr 16, 2019
Closed
4 tasks
@richardlau
Copy link
Member

In the long run we should add tools to prevent this ?
I wonder can https://github.com/JustinBeckwith/linkinator integrate to travis-ci ? (Suggested by @bnb )

It's technically possible but would need work: #27267

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3311/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 20, 2019
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Apr 20, 2019 •
edited
Loading

Landed in 964174e.
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Apr 20, 2019
@07Gond @vsemozhetbyt
tools,doc: fix 404 broken links in docs
964174e 
Change the `linkManPages()` function to catch the `uname` and `curl`
correct websites on the docs page.

PR-URL: #27168
Fixes: #26074
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Apr 23, 2019
Closed
Closed
@07Gond 07Gond deleted the doc-broken-links branch April 23, 2019 17:53
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@jasnell jasnell jasnell approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: Broken (404ing) links in Docs
7 participants
@07Gond @gengjiawen @richardlau @vsemozhetbyt @jasnell @BridgeAR @nodejs-github-bot