console: remove trace frame #27159
Closed
console: remove trace frame #27159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The own function's frame was removed originally. This restors that behavior. Fixes: nodejs#27134
nodejs-github-bot
added
the
console
eugeneo
approved these changes
Apr 9, 2019
richardlau
approved these changes
Apr 9, 2019
targos
approved these changes
Apr 9, 2019
| @@ -330,13 +330,13 @@ const consoleMethods = { | |||
| trace(kTraceInstant, kTraceConsoleCategory, `time::${label}`, 0); | |||
| }, | |||
|
|
|||
| trace(...args) { | |||
| trace: function trace(...args) { | |||
There was a problem hiding this comment.
Is this strictly needed? I thought the shorthand notation had the same behavior.
There was a problem hiding this comment.
With the shorthand notation, the function would be called as obj.property. It is not possible to access the function itself by only using the property name. That is only possible inside the old function foo type.
It would also be possible if this would not be a property but a variable.
jasnell
approved these changes
Apr 10, 2019
BridgeAR
added
the
author ready
ZYSzys
approved these changes
Apr 10, 2019
lpinca
approved these changes
Apr 10, 2019
ChALkeR
approved these changes
Apr 10, 2019
|
Landed in 091902a 🎉 |
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 12, 2019
The own function's frame was removed originally. This restors that behavior. Fixes: nodejs#27134 PR-URL: nodejs#27159 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The own function's frame was removed originally. This restors that
behavior.
Fixes: #27134
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes