doc: revise Collaborator description in GOVERNANCE.md #27071
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Active voice * Remove Node.js Foundation mention. It may be appropriate to add something back in when the new foundation is bootstrapped. We don't control membership criteria, so best to link to something else when it becomes available rather than make guarantees in this doc.
nodejs-github-bot
added
the
meta
antsmartian
approved these changes
Apr 3, 2019
Trott
added
the
author ready
vsemozhetbyt
approved these changes
Apr 3, 2019
lpinca
approved these changes
Apr 3, 2019
richardlau
approved these changes
Apr 3, 2019
ZYSzys
approved these changes
Apr 4, 2019
jasnell
approved these changes
Apr 4, 2019
hiroppy
approved these changes
Apr 4, 2019
|
Landed in 181052d |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 5, 2019
* Active voice * Remove Node.js Foundation mention. It may be appropriate to add something back in when the new foundation is bootstrapped. We don't control membership criteria, so best to link to something else when it becomes available rather than make guarantees in this doc. PR-URL: nodejs#27071 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
something back in when the new foundation is bootstrapped. We
don't control membership criteria, so best to link to something else
when it becomes available rather than make guarantees in this doc.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes