src: don't point to out of scope variable #27070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity reported this. The addr pointer is passed to req_wrap->Dispatch(). By the time this happens, the value that addr points to, addr_storage, is out of scope. This commit remedies that.
nodejs-github-bot
added
c++
addaleax
approved these changes
Apr 3, 2019
richardlau
approved these changes
Apr 3, 2019
devsnek
approved these changes
Apr 3, 2019
lpinca
approved these changes
Apr 3, 2019
ZYSzys
approved these changes
Apr 4, 2019
ZYSzys
added
the
author ready
|
CI: https://ci.nodejs.org/job/node-test-pull-request/22186/ EDIT(cjihrig): CI was green. |
JungMinu
approved these changes
Apr 5, 2019
|
Landed in 97c0a34 🎉 |
ZYSzys
pushed a commit
that referenced
this pull request
Apr 7, 2019
Coverity reported this. The addr pointer is passed to req_wrap->Dispatch(). By the time this happens, the value that addr points to, addr_storage, is out of scope. This commit remedies that. PR-URL: #27070 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity reported this. The
addrpointer is passed toreq_wrap->Dispatch(). By the time this happens, the value thataddrpoints to,addr_storage, is out of scope. This commit remedies that.cc: @santigimeno
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes