Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move test-net-connect-handle-econnrefused to sequential #27014

Closed
wants to merge 2 commits into from
Closed

test: move test-net-connect-handle-econnrefused to sequential #27014

wants to merge 2 commits into from

Commits on Mar 30, 2019

  1. test: move test-net-connect-handle-econnrefused 

    The port used in the test could be taken by another process before
the callback of `server.close()` is called. Move it to sequential.

Refs: nodejs#18257 (comment)
Fixes: nodejs#26907
    @lpinca
    lpinca committed Mar 30, 2019
    Configuration menu
    Copy the full SHA
    c1c2b5c View commit details
    Browse the repository at this point in the history

  2. test: refactor net-connect-handle-econnrefused 

    - Remove unneeded server
- Use `common.PORT`
    @lpinca
    lpinca committed Mar 30, 2019
    Configuration menu
    Copy the full SHA
    325fd72 View commit details
    Browse the repository at this point in the history