Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add note about mkdtemp() platform differences #26944

Merged
merged 1 commit into from
Mar 30, 2019
Merged

doc: add note about mkdtemp() platform differences #26944

merged 1 commit into from
Mar 30, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 27, 2019

Fixes: #26435

I'm not sure how strongly anyone feels about this, but I could potentially emit a warning if the provided prefix string ends with X.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3068/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Mar 27, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 27, 2019
apapirovski
apapirovski approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good but I do wonder whether a warning would be more clear. I imagine most people will find this after trying to debug this issue for a while rather than before.

@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 28, 2019

@apapirovski I'll add the warning. I think it will be a source of bugs and frustration if it does happen. Most people would never see the warning anyway.

@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 29, 2019

@apapirovski warning added in #26980.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22023/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 30, 2019 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/22024/

EDIT(cjihrig): CI was green.

@cjihrig
doc: add note about mkdtemp() platform differences
dd9cad9 
PR-URL: nodejs#26944
Fixes: nodejs#26435
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@cjihrig cjihrig merged commit dd9cad9 into nodejs:master Mar 30, 2019
@cjihrig cjihrig deleted the docs branch March 30, 2019 01:46
@vtjnash vtjnash mentioned this pull request Mar 30, 2019
Open
@joyeecheung joyeecheung mentioned this pull request Apr 2, 2019
Closed
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@cjihrig @BethGriggs
doc: add note about mkdtemp() platform differences
dc1fa76 
PR-URL: #26944
Fixes: #26435
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
BethGriggs pushed a commit that referenced this pull request Apr 8, 2019
@cjihrig @BethGriggs
doc: add note about mkdtemp() platform differences
d76c30c 
PR-URL: #26944
Fixes: #26435
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mkdtemp doc issue?
5 participants
@cjihrig @nodejs-github-bot @apapirovski @lpinca @BridgeAR