Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules: fix repl require calling the same file again #26928

Closed
wants to merge 1 commit into from
Closed

modules: fix repl require calling the same file again #26928

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

This makes sure multiple require calls will not fail in case a file
was created after the first attempt.

Fixes: #26926

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3055/pipeline

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/21908/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 26, 2019 •
edited by BridgeAR
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/21925/ ✔️

@BridgeAR
Copy link
Member Author

@nodejs/modules PTAL

@BridgeAR
modules: fix repl require calling the same file again
c3aba6c 
This makes sure multiple require calls will not fail in case a file
was created after the first attempt.
@BridgeAR
Copy link
Member Author

Rebased due to conflicts. @nodejs/modules PTAL

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22057/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 31, 2019 •
edited by BridgeAR
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/22068/ ✔️

@BridgeAR
Copy link
Member Author

BridgeAR commented Apr 1, 2019

@nodejs/modules this could use some reviews. It fixes a minor regression.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 1, 2019
This was referenced Apr 2, 2019
Closed
Closed
@BridgeAR BridgeAR requested a review from bnoordhuis April 3, 2019 02:03
@BridgeAR
Copy link
Member Author

BridgeAR commented Apr 3, 2019 •
edited
Loading

This could use another review.

BridgeAR added a commit to BridgeAR/node that referenced this pull request Apr 3, 2019
@BridgeAR
module: fix repl require calling the same file again
8a6dcd0 
This makes sure multiple require calls will not fail in case a file
was created after the first attempt.

PR-URL: nodejs#26928
Fixes: nodejs#26926
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
@BridgeAR
Copy link
Member Author

BridgeAR commented Apr 3, 2019

Landed in 8a6dcd0 🎉

@BridgeAR BridgeAR closed this Apr 3, 2019
BethGriggs pushed a commit that referenced this pull request Apr 4, 2019
@BridgeAR @BethGriggs
module: fix repl require calling the same file again
6179a7f 
This makes sure multiple require calls will not fail in case a file
was created after the first attempt.

PR-URL: #26928
Fixes: #26926
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@BridgeAR @BethGriggs
module: fix repl require calling the same file again
079368a 
This makes sure multiple require calls will not fail in case a file
was created after the first attempt.

PR-URL: #26928
Fixes: #26926
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 10, 2019
@BridgeAR @BethGriggs
module: fix repl require calling the same file again
58da879 
This makes sure multiple require calls will not fail in case a file
was created after the first attempt.

PR-URL: #26928
Fixes: #26926
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
@BridgeAR BridgeAR deleted the fix-repl-require branch January 20, 2020 11:59
@benjamingr benjamingr mentioned this pull request Feb 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkrems jkrems jkrems approved these changes

@guybedford guybedford guybedford approved these changes

@cjihrig cjihrig Awaiting requested review from cjihrig

@jasnell jasnell Awaiting requested review from jasnell

@mcollina mcollina Awaiting requested review from mcollina

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module stat cache keeps broken results in cache
4 participants
@BridgeAR @nodejs-github-bot @jkrems @guybedford