Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused variable #26879

Merged
merged 1 commit into from
Mar 23, 2019
Merged

src: remove unused variable #26879

merged 1 commit into from
Mar 23, 2019
+0 −1

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 23, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3020/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 23, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 23, 2019

👍 to fast track

@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 23, 2019 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/21831/

EDIT: CI was green.

@cjihrig cjihrig added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 23, 2019
@cjihrig
src: remove unused variable
c0f031c 
PR-URL: nodejs#26879
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cjihrig cjihrig merged commit c0f031c into nodejs:master Mar 23, 2019
@cjihrig cjihrig deleted the unused branch March 23, 2019 21:35
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@aymen94 aymen94 aymen94 approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @lpinca @targos @aymen94 @ZYSzys