Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION #26821

Closed
wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@sam-github sam-github added tls Issues and PRs related to the tls subsystem. doc Issues and PRs related to the documentations. labels Mar 20, 2019
@sam-github
Copy link
Contributor Author

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2019
@sam-github
Copy link
Contributor Author

Landed in d989e20

@sam-github sam-github closed this Mar 25, 2019
sam-github added a commit that referenced this pull request Mar 25, 2019
PR-URL: #26821
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this pull request Mar 26, 2019
PR-URL: #26821
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos
Copy link
Member

targos commented Mar 28, 2019

IIUC this should land with or after #26951

@sam-github sam-github deleted the doc-default-max-min branch March 29, 2019 17:17
@sam-github
Copy link
Contributor Author

will cherry pick onto the backport for tls1.3

@sam-github sam-github mentioned this pull request Mar 29, 2019
4 tasks
sam-github added a commit to sam-github/node that referenced this pull request Apr 1, 2019
PR-URL: nodejs#26821
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
sam-github added a commit to sam-github/node that referenced this pull request Apr 11, 2019
PR-URL: nodejs#26821
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this pull request Apr 15, 2019
Backport-PR-URL: #26951
PR-URL: #26821
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Apr 19, 2019
@Trott
Copy link
Member

Trott commented Jul 18, 2019

This looks like it went out in 11.15.0, so I'm going to change backport-requested-v11.x label for backported-to-v11.x label. Hope that's the right thing to do.

@Trott
Copy link
Member

Trott commented Jul 18, 2019

Looks like DEFAULT_MIN_VERSION was in 10.16.0 but no documentation is in 10.16.0 for it. Does this need a v10.x backport? Cherry-pick? Neither? @sam-github @BethGriggs

@Trott
Copy link
Member

Trott commented Jul 18, 2019

(Refs: #28758. That should be closed once this is in 10.x-staging, I suppose.)

@sam-github
Copy link
Contributor Author

@nitinsurana do you have time to backport the 11.x version of this, fa6f0f1, to 10.x? It would be fairly straight-forward, but all references to TLSv1.3 would have to be removed.

I added the various labels, but don't know when this will hit the top of my TODO list.

@nitinsurana
Copy link

@sam-github Sure; let me give it a try.

ckarande added a commit to ckarande/node that referenced this pull request Jul 23, 2019
Add documentation for tls.DEFAULT_MAX_VERSION and
tls.DEFAULT_MIN_VERSION, which existed in v10.6.0

Fixes: nodejs#28758
Refs: nodejs#26821
BethGriggs pushed a commit that referenced this pull request Oct 7, 2019
Add documentation for tls.DEFAULT_MAX_VERSION and
tls.DEFAULT_MIN_VERSION, which existed in v10.6.0

Fixes: #28758
Refs: #26821

PR-URL: #28827
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Oct 7, 2019
PR-URL: #28827
Fixes: #28758
Refs: #26821
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants