Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 7.4 #26685

Merged
merged 23 commits into from
Mar 28, 2019
Merged

deps: update V8 to 7.4 #26685

merged 23 commits into from
Mar 28, 2019

Conversation

ryzokuken
Copy link
Contributor

ETA: April 23rd, 2019
Intended to supersede #25852

/cc @targos 🎉

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Mar 15, 2019
@ryzokuken ryzokuken added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 15, 2019
@ryzokuken
Copy link
Contributor Author

@addaleax addaleax added this to the 12.0.0 milestone Mar 15, 2019
@targos
Copy link
Member

targos commented Mar 15, 2019

/cc @nodejs/v8-update

@addaleax
Copy link
Member

@ryzokuken @targos If you want, feel free to include 3ba72b5...51a9301 (v8-7.4 branch on my fork) – all of them are clean cherry-picks of upstream commits, and bring us to API + ABI backwards compatibility with V8 master. I can also push them directly to this branch, if you prefer.

(Adding v8/v8@de7ab39 to that would actually bring us to 1:1 identical APIs, but it’s purely additive and would be just part of a V8 7.5 semver-minor bump on our side.)

CI for those commits: https://ci.nodejs.org/job/node-test-commit/26781/
V8 CI for those commits: https://ci.nodejs.org/job/node-test-commit-v8-linux/2170/

@refack
Copy link
Contributor

refack commented Mar 16, 2019

@ryzokuken would you consider adding on-behalf-of: @nodejs <about@nodejs.org> to the tail of the first commit message. As per the brand new https://help.github.com/en/articles/creating-a-commit-on-behalf-of-an-organization.

@ryzokuken
Copy link
Contributor Author

@refack I'd be more than happy to do so. That said, I personally believe it's more suited to the case where commits are made to a repository in org X by a person representing org Y, thus on behalf of the entire organization. For instance, I think upstreaming patches to V8 can be done using this.

Also, I don't think this applies for me anyway:

your commit email and the organization email must be in a domain verified by the organization

@refack
Copy link
Contributor

refack commented Mar 16, 2019

That said, I personally believe it's more suited to the case where commits are made to a repository in org X by a person representing org Y, thus on behalf of the entire organization. For instance, I think upstreaming patches to V8 can be done using this.

Yeah, it's worth thinking about and discussing some more. As I see it, it's useful as a way to disclaim changes that are not original work by the commiter...

Actually the designation should probably be on-behalf-of: @v8 <about@v8.dev>

@ryzokuken
Copy link
Contributor Author

Actually the designation should probably be on-behalf-of: @v8 about@v8.dev

@refack this sounds much closer to the real situation, and I wholeheartedly agree on discussing it further. For now, I'll add on-behalf-of: @v8 <about@v8.dev> to the commits picked up from V8 directly having no real changes done by us.

@ryzokuken
Copy link
Contributor Author

BTW, I just realized that the following don't hold up for me:

  • you must be a member of the organization indicated in the trailer
  • your commit email and the organization email must be in a domain verified by the organization

Because of these, I don't think I can make commits on "behalf of" V8. I will pick this up with the V8 team.

@refack
Copy link
Contributor

refack commented Mar 16, 2019

Fixes: #26694

@ryzokuken
Copy link
Contributor Author

@targos @addaleax @refack PTAL.

@targos
Copy link
Member

targos commented Mar 16, 2019

segfault on LinuxONE. Maybe because of f1d3b41 ?

@targos
Copy link
Member

targos commented Mar 16, 2019

Yeah, we probably need to cherry-pick other commits. There are some with a message like " Prepare for changing kTaggedSize"

@refack
Copy link
Contributor

refack commented Mar 16, 2019

FYI: I'm strongly considering deprecating the use of pure numbers as values for GYP3 (I want it to be pure strings)...
So in python we might want to use

def b(opt):
	return 'true' if opt else ''

this way in the .gyp we can do:

	conditions: [
		["opt", {}, {}],
		["not opt2", {}, {}],
	],

but I need to think about this some more.

@refack
Copy link
Contributor

refack commented Mar 16, 2019

BTW: what the tl;dr about the timeline for landing this?

@targos
Copy link
Member

targos commented Mar 16, 2019

BTW: what the tl;dr about the timeline for landing this?

ASAP to have it in v12 release candidates

@targos
Copy link
Member

targos commented Mar 16, 2019

I cherry-picked all remaining commits related to v8:7703 (and v8/v8@4e6a1a7 to avoid a conflict)

Hopefully we're good: https://ci.nodejs.org/job/node-test-pull-request/21595/

@targos
Copy link
Member

targos commented Mar 16, 2019

Weird, both Windows builders failed git commands.
FreeBSD was disconnected while running tests.

macOS and AIX were already failing before the cherry-picks.
/cc @nodejs/platform-macos @nodejs/platform-aix

@targos
Copy link
Member

targos commented Mar 16, 2019

BTW, this version of V8 breaks our V8-CI because: run-tests.py: error: no such option: --junitout

@refack
Copy link
Contributor

refack commented Mar 17, 2019

V8-CI issue is nodejs/node-v8#100
Requested a revert in https://chromium-review.googlesource.com/c/v8/v8/+/1430065

nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Nov 2, 2020
PR-URL: nodejs/node#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs/node#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Nov 3, 2020
PR-URL: nodejs/node#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs/node#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Nov 4, 2020
PR-URL: nodejs/node#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs/node#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Nov 6, 2020
PR-URL: nodejs/node#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs/node#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Nov 7, 2020
PR-URL: nodejs/node#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs/node#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Nov 8, 2020
PR-URL: nodejs/node#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs/node#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Nov 9, 2020
PR-URL: nodejs/node#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs/node#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Nov 10, 2020
PR-URL: nodejs/node#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs/node#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Nov 11, 2020
PR-URL: nodejs/node#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs/node#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Nov 12, 2020
PR-URL: nodejs/node#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs/node#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Nov 13, 2020
PR-URL: nodejs/node#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs/node#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Nov 14, 2020
PR-URL: nodejs/node#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs/node#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Nov 15, 2020
PR-URL: nodejs/node#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs/node#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos added a commit to targos/node that referenced this pull request Nov 15, 2020
PR-URL: nodejs#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos added a commit that referenced this pull request Nov 16, 2020
PR-URL: #26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Nov 16, 2020
PR-URL: nodejs/node#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs/node#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos added a commit to targos/node that referenced this pull request Nov 19, 2020
PR-URL: nodejs#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos added a commit to targos/node that referenced this pull request Nov 29, 2020
PR-URL: nodejs#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 6, 2020
PR-URL: nodejs#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos added a commit to targos/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos added a commit to targos/node that referenced this pull request Jan 25, 2021
PR-URL: nodejs#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos added a commit to targos/node that referenced this pull request Feb 7, 2021
PR-URL: nodejs#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos added a commit to targos/node that referenced this pull request Feb 11, 2021
PR-URL: nodejs#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos added a commit to targos/node that referenced this pull request Feb 11, 2021
PR-URL: nodejs#26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs#32116
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants