[v11.x backport] process: move more dependency of environment variables to pre-execution #26662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Last CI was positive so: |
2 tasks
4 tasks
Since we should treat the node-inspect as third-party user code. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Since it depends on environment variables. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Since this depends on environment variable, and the worker threads do not need to persist the variable value because they cannot switch cwd. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
refack
force-pushed
the
backport-26466-to-v11.x
branch
from
93795d9
to
f442b54
Compare
|
Rebased & CI: https://ci.nodejs.org/job/node-test-pull-request/21611/ |
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
Since we should treat the node-inspect as third-party user code. Backport-PR-URL: nodejs#26662 PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
Since it depends on environment variables. Backport-PR-URL: nodejs#26662 PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
Since this depends on environment variable, and the worker threads do not need to persist the variable value because they cannot switch cwd. Backport-PR-URL: nodejs#26662 PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
PR-URL: nodejs#26662 Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Landed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #26466
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes