Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update http2.md #26616

Closed
wants to merge 1 commit into from
Closed

Update http2.md #26616

wants to merge 1 commit into from

Conversation

TJKoury
Copy link
Contributor

@TJKoury TJKoury commented Mar 12, 2019 •
edited
Loading

sendTrilers => sendTrailers.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@TJKoury
Update http2.md
581e40e 
sendTrilers => sendTrailers.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Mar 12, 2019
@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2883/

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 12, 2019
@vsemozhetbyt
Copy link
Contributor

Landed in 8cbbe73
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Mar 12, 2019
@TJKoury @vsemozhetbyt
doc: fix typo in http2.md
8cbbe73 
sendTrilers => sendTrailers.

PR-URL: #26616
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@TJKoury TJKoury deleted the patch-1 branch March 12, 2019 20:17
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@TJKoury @BridgeAR
doc: fix typo in http2.md
bb6b572 
sendTrilers => sendTrailers.

PR-URL: #26616
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 14, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
@TJKoury @BridgeAR
doc: fix typo in http2.md
c74fc63 
sendTrilers => sendTrailers.

PR-URL: nodejs#26616
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@TJKoury @BridgeAR
doc: fix typo in http2.md
6f68570 
sendTrilers => sendTrailers.

PR-URL: #26616
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@TJKoury @BethGriggs
doc: fix typo in http2.md
f30172f 
sendTrilers => sendTrailers.

PR-URL: #26616
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TJKoury @vsemozhetbyt @jasnell @cjihrig @richardlau @nodejs-github-bot