Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: forbid access to CLI options before bootstrapping is done #26476

Closed
wants to merge 1 commit into from
Closed

src: forbid access to CLI options before bootstrapping is done #26476

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2786/pipeline

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Mar 6, 2019
@joyeecheung
Copy link
Member Author

joyeecheung commented Mar 6, 2019 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/21273/ (:heavy_check_mark:)

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 6, 2019
@joyeecheung
Copy link
Member Author

Landed in d57d099

@joyeecheung joyeecheung closed this Mar 9, 2019
joyeecheung added a commit that referenced this pull request Mar 9, 2019
@joyeecheung
src: forbid access to CLI options before bootstrapping is done
d57d099 
PR-URL: #26476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BridgeAR
Copy link
Member

This lands cleanly v11.x but it causes test failures. Please open a manual backport for this. I guess this relies on some other commits that have to be backported as well (likely the ones I marked as requiring a backport to v11).

targos pushed a commit that referenced this pull request Mar 28, 2019
@joyeecheung @targos
src: forbid access to CLI options before bootstrapping is done
beac445 
PR-URL: #26476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit that referenced this pull request Mar 30, 2019
@joyeecheung @targos
src: forbid access to CLI options before bootstrapping is done
63e7cc7 
PR-URL: #26476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
@RaisinTen RaisinTen mentioned this pull request Feb 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joyeecheung @nodejs-github-bot @BridgeAR @addaleax @richardlau @targos