Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: only set v8 flags if argc > 1 #2646

Closed
wants to merge 1 commit into from
Closed

src: only set v8 flags if argc > 1 #2646

wants to merge 1 commit into from

Commits on Sep 2, 2015

  1. src: only set v8 flags if argc > 1 

    ParseArgs sets the first element of v8_args to argv[0], so v8_argc will
always be at least 1. This change only calls
V8::SetFlagsFromCommandLine if v8_argc > 1, leading to an additional
startup improvement of ~5%.
    @evanlucas
    evanlucas committed Sep 2, 2015
    Configuration menu
    Copy the full SHA
    05af17d View commit details
    Browse the repository at this point in the history