Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing https Agent maxCachedSessions #26433

Closed
wants to merge 1 commit into from
Closed

doc: add missing https Agent maxCachedSessions #26433

wants to merge 1 commit into from

Conversation

nicolas-moteau
Copy link
Contributor

Refs: #2228
Refs: #4252

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. https Issues or PRs related to the https subsystem. labels Mar 4, 2019
@BridgeAR BridgeAR requested review from lpinca and mcollina March 5, 2019 23:26
lpinca
lpinca approved these changes Mar 6, 2019
View reviewed changes
doc/api/https.md Outdated Show resolved Hide resolved
doc/api/https.md Outdated Show resolved Hide resolved
@nicolas-moteau
Copy link
Contributor Author

@lpinca, thanks for the the remarks. I made the modifications.

@BridgeAR
Copy link
Member

BridgeAR commented Mar 6, 2019

Lite CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2783/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 6, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 6, 2019
@nicolas-moteau @BridgeAR
doc: add missing https Agent maxCachedSessions
d50fc51 
PR-URL: nodejs#26433
Refs: nodejs#2228
Refs: nodejs#4252
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

BridgeAR commented Mar 6, 2019

Landed in d50fc51 🎉

@BridgeAR BridgeAR closed this Mar 6, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@nicolas-moteau @BridgeAR
doc: add missing https Agent maxCachedSessions
4b1c1dc 
PR-URL: nodejs#26433
Refs: nodejs#2228
Refs: nodejs#4252
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@nicolas-moteau @BridgeAR
doc: add missing https Agent maxCachedSessions
6cc559f 
PR-URL: #26433
Refs: #2228
Refs: #4252
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@mcollina mcollina Awaiting requested review from mcollina

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. https Issues or PRs related to the https subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-moteau @BridgeAR @lpinca @nodejs-github-bot