util: improve inspect compact #26269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BridgeAR sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
the
util
richardlau
reviewed
Feb 23, 2019
jasnell
approved these changes
Feb 23, 2019
mscdex
reviewed
Feb 23, 2019
addaleax
approved these changes
Feb 24, 2019
|
@addaleax I'll add a couple of comments to the code. I hope that'll help? And is there a specific part with which you struggled most / something that I should definitely explain? |
|
@BridgeAR Tbh, I’m having trouble with the string-building parts of the I think comments would be great, but comments with examples of how the calculation plays out in the end would be the most helpful thing here…? |
|
I just pushed another commit that includes a lot of documentation, further tests and it also improves the grouping logic further and makes sure array grouping and line combining does not happen at the same time. |
BridgeAR
added
the
author ready
|
@addaleax @jasnell would you be so kind and confirm your LG due to the recent changes? @Trott @vsemozhetbyt it would be great if either of you could also review this. |
addaleax
approved these changes
Feb 28, 2019
|
Documentation and tests LGTM. |
This overloads the `compact` option from `util.inspect()`. If it's set to a number, it is going to align all most inner entries on the same lign if they adhere to the following: * The entries do not exceed the `breakLength` options value. * The entry is one of the local most inner levels up the the one provided in `compact`.
When using `util.inspect()` with `compact` mode set to a number, all array entries exceeding 6 are going to be grouped together into logical parts.
BridgeAR
force-pushed
the
improve-inspect-compact
branch
from
2307913
to
2163a25
Compare
|
Rebased due to conflicts (besides that there were no changes, just the typo fixed). CI https://ci.nodejs.org/job/node-test-pull-request/21060/ ✔️ |
BridgeAR
added
the
semver-minor
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Feb 28, 2019
This overloads the `compact` option from `util.inspect()`. If it's set to a number, it is going to align all most inner entries on the same lign if they adhere to the following: * The entries do not exceed the `breakLength` options value. * The entry is one of the local most inner levels up the the one provided in `compact`. PR-URL: nodejs#26269 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Feb 28, 2019
When using `util.inspect()` with `compact` mode set to a number, all array entries exceeding 6 are going to be grouped together into logical parts. PR-URL: nodejs#26269 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Mar 1, 2019
This overloads the `compact` option from `util.inspect()`. If it's set to a number, it is going to align all most inner entries on the same lign if they adhere to the following: * The entries do not exceed the `breakLength` options value. * The entry is one of the local most inner levels up the the one provided in `compact`. PR-URL: #26269 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Mar 1, 2019
When using `util.inspect()` with `compact` mode set to a number, all array entries exceeding 6 are going to be grouped together into logical parts. PR-URL: #26269 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
BridgeAR
added a commit
that referenced
this pull request
Mar 5, 2019
Notable Changes
* n-api:
* Implement date object (Jarrod Connolly)
#25917
* util:
* Add compact depth mode for `util.inspect()` (Ruben Bridgewater)
#26269
* worker:
* Improve integration with native addons (Anna Henningsen)
#26175
* MessagePort.prototype.onmessage takes arguments closer to the Web
specification now (Anna Henningsen)
#26082
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Mar 6, 2019
Notable Changes
* n-api:
* Implement date object (Jarrod Connolly)
nodejs#25917
* util:
* Add compact depth mode for `util.inspect()` (Ruben Bridgewater)
nodejs#26269
* worker:
* Improve integration with native addons (Anna Henningsen)
nodejs#26175
* MessagePort.prototype.onmessage takes arguments closer to the Web
specification now (Anna Henningsen)
nodejs#26082
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the commit messages for a closer description.
The tests visualize the differences.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes