Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify http.ClientRequest path description #26259

Merged
merged 1 commit into from
Feb 26, 2019
Merged

doc: clarify http.ClientRequest path description #26259

merged 1 commit into from
Feb 26, 2019

Conversation

JungMinu
Copy link
Member

This PR clarifies http.ClientRequest path description.
Fixes: #25864

Checklist

@nodejs-github-bot
Copy link
Collaborator

@JungMinu sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Feb 22, 2019
@JungMinu JungMinu self-assigned this Feb 22, 2019
@JungMinu JungMinu requested a review from mscdex February 22, 2019 11:31
Clarify `http.ClientRequest` path description.

Fixes: #25864
PR-URL: #26259
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@JungMinu
Copy link
Member Author

Landed in 2e125cc

@JungMinu JungMinu merged commit 2e125cc into nodejs:master Feb 26, 2019
@JungMinu JungMinu deleted the minwoo/fix-25864 branch February 26, 2019 02:07
addaleax pushed a commit that referenced this pull request Mar 1, 2019
Clarify `http.ClientRequest` path description.

Fixes: #25864
PR-URL: #26259
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: http.ClientRequest path property description needs clarification
3 participants