Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: clean unused macro in inspector_socket.cc #26158

Closed
wants to merge 1 commit into from
Closed

src: clean unused macro in inspector_socket.cc #26158

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol labels Feb 17, 2019
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/20920/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 20, 2019
@gengjiawen gengjiawen mentioned this pull request Feb 27, 2019
Closed
2 tasks
@danbev
Copy link
Contributor

danbev commented Feb 27, 2019

Landed in 8a273f1.

@danbev danbev closed this Feb 27, 2019
danbev pushed a commit that referenced this pull request Feb 27, 2019
@gengjiawen @danbev
src: clean unused macro in inspector_socket.cc
8a273f1 
PR-URL: #26158
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gengjiawen gengjiawen deleted the cleanup_unused_macro branch February 27, 2019 08:49
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@gengjiawen @addaleax
src: clean unused macro in inspector_socket.cc
3e0978d 
PR-URL: #26158
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gengjiawen @BridgeAR @danbev @jasnell @addaleax @cjihrig @nodejs-github-bot