Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused method in env.h #25934

Closed
wants to merge 1 commit into from
Closed

src: remove unused method in env.h #25934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions src/env.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,25 +829,6 @@ void CollectExceptionInfo(Environment* env,
}
}

void Environment::CollectExceptionInfo(Local<Value> object,
int errorno,
const char* syscall,
const char* message,
const char* path) {
if (!object->IsObject() || errorno == 0)
return;

Local<Object> obj = object.As<Object>();
const char* err_string = errors::errno_string(errorno);

if (message == nullptr || message[0] == '\0') {
message = strerror(errorno);
}

node::CollectExceptionInfo(this, obj, errorno, err_string,
syscall, message, path, nullptr);
}

void Environment::CollectUVExceptionInfo(Local<Value> object,
int errorno,
const char* syscall,
Expand Down
6 changes: 0 additions & 6 deletions src/env.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,12 +745,6 @@ class Environment {
inline performance::performance_state* performance_state();
inline std::unordered_map<std::string, uint64_t>* performance_marks();

void CollectExceptionInfo(v8::Local<v8::Value> context,
int errorno,
const char* syscall = nullptr,
const char* message = nullptr,
const char* path = nullptr);

void CollectUVExceptionInfo(v8::Local<v8::Value> context,
int errorno,
const char* syscall = nullptr,
Expand Down