Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: disambiguate glibc versions #25781

Merged
merged 1 commit into from
Jan 31, 2019
Merged

report: disambiguate glibc versions #25781

merged 1 commit into from
Jan 31, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 29, 2019

  • Give the glibc version entries more specific names.
  • Group all of the glibc version reporting together.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2434/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 29, 2019
richardlau
richardlau approved these changes Jan 29, 2019
View reviewed changes
doc/api/report.md Outdated Show resolved Hide resolved
@addaleax addaleax added the report Issues and PRs related to process.report. label Jan 29, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 30, 2019

Green CI: https://ci.nodejs.org/job/node-test-pull-request/20425/

@cjihrig
report: disambiguate glibc versions
5d4b085 
- Give the glibc version entries more specific names.
- Group all of the glibc version reporting together.

PR-URL: nodejs#25781
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit 5d4b085 into nodejs:master Jan 31, 2019
addaleax pushed a commit that referenced this pull request Feb 1, 2019
@cjihrig @addaleax
report: disambiguate glibc versions
b1e0c43 
- Give the glibc version entries more specific names.
- Group all of the glibc version reporting together.

PR-URL: #25781
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @jasnell @addaleax @richardlau @gireeshpunathil