Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: reuse noop function in socketOnError() #25566

Merged
merged 1 commit into from
Jan 20, 2019
Merged

http: reuse noop function in socketOnError() #25566

merged 1 commit into from
Jan 20, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 18, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2285/pipeline

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Jan 18, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 19, 2019

Green CI: https://ci.nodejs.org/job/node-test-pull-request/20208/

@cjihrig
http: reuse noop function in socketOnError()
5571c0d 
PR-URL: nodejs#25566
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cjihrig cjihrig merged commit 5571c0d into nodejs:master Jan 20, 2019
@cjihrig cjihrig deleted the noop branch January 20, 2019 20:40
addaleax pushed a commit that referenced this pull request Jan 23, 2019
@cjihrig @addaleax
http: reuse noop function in socketOnError()
e55c5c3 
PR-URL: #25566
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@cjihrig @BethGriggs
http: reuse noop function in socketOnError()
ff30a37 
PR-URL: #25566
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@cjihrig @BethGriggs
http: reuse noop function in socketOnError()
58ecc3d 
PR-URL: #25566
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@cjihrig @MylesBorins
http: reuse noop function in socketOnError()
33a9d17 
PR-URL: #25566
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjihrig @nodejs-github-bot @jasnell @lpinca