test: ensure npm version is not release candidate #25538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
reviewed
Jan 16, 2019
cjihrig
reviewed
Jan 16, 2019
MylesBorins
force-pushed
the
no-npm-rc
branch
2 times, most recently
from
3fa37d5
to
0161c61
Compare
v11.6.0 ended up shipping with an npm version `6.5.0-next.0`. This test should avoid it happening in the future.
MylesBorins
force-pushed
the
no-npm-rc
branch
from
0161c61
to
134a8c5
Compare
|
All feedback incorporated. PTAL |
ljharb
approved these changes
Jan 16, 2019
richardlau
approved these changes
Jan 16, 2019
cjihrig
approved these changes
Jan 16, 2019
BridgeAR
approved these changes
Jan 16, 2019
targos
approved these changes
Jan 17, 2019
jasnell
approved these changes
Jan 17, 2019
JungMinu
approved these changes
Jan 18, 2019
|
Landed in 2e613a9 |
MylesBorins
added a commit
that referenced
this pull request
Jan 18, 2019
v11.6.0 ended up shipping with an npm version `6.5.0-next.0`. This test should avoid it happening in the future. PR-URL: #25538 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Trott
reviewed
Jan 18, 2019
| ); | ||
|
|
||
| const pkg = require(npmPathPackageJson); | ||
| assert(pkg.version.match(/^\d+\.\d+\.\d+$/), |
There was a problem hiding this comment.
Suggested change
| assert(pkg.version.match(/^\d+\.\d+\.\d+$/), | |
| assert.ok(/^\d+.\d+.\d+$/.test(pkg.version.match), |
addaleax
pushed a commit
that referenced
this pull request
Jan 23, 2019
v11.6.0 ended up shipping with an npm version `6.5.0-next.0`. This test should avoid it happening in the future. PR-URL: #25538 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v11.6.0 ended up shipping with an npm version
6.5.0-next.0.This test should avoid it happening in the future.