Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: do not free cert in .getCertificate() #25490

Closed
wants to merge 1 commit into from
Closed

tls: do not free cert in .getCertificate() #25490

wants to merge 1 commit into from

Commits on Jan 14, 2019

  1. tls: do not free cert in .getCertificate() 

    The documentation of `SSL_get_certificate` states that it returns
an internal pointer that must not be freed by the caller.

Therefore, using a smart pointer to take ownership is incorrect.

Refs: https://man.openbsd.org/SSL_get_certificate.3
Refs: nodejs#24261
Fixes: https://github.com/nodejs-private/security/issues/217
    @addaleax
    addaleax committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    7611f1b View commit details
    Browse the repository at this point in the history