Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: move per-process global variables into node::per_process #25302

Closed
wants to merge 2 commits into from
Closed

src: move per-process global variables into node::per_process #25302

wants to merge 2 commits into from

Commits on Jan 4, 2019

  1. src: move per-process global variables into node::per_process 

    So that it's easier to tell whether we are manipulating per-process
global states that may need to be treated with care to avoid races.

Also added comments about these variables and moved some of them
to a more suitable compilation unit:

- Move `v8_initialized` to `util.h` since it's only used in
  `util.cc` and `node.cc`
- Rename `process_mutex` to `tty_mutex` and move it into
  `node_errors.cc` since that's the only place it's used
  to guard the tty.
- Move `per_process_opts_mutex` and `per_process_opts`
  into `node_options.h` and rename them to
  `per_process::cli_options[_mutex]`
- Rename `node_isolate[_mutex]` to `per_process::main_isolate[_mutex]`
    @joyeecheung
    joyeecheung committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    11ed69e View commit details
    Browse the repository at this point in the history

  2. fixup! src: move per-process global variables into node::per_process

    @joyeecheung
    joyeecheung committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    3a58828 View commit details
    Browse the repository at this point in the history