Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: edit and simplify util.inspect() docs #25195

Merged
merged 1 commit into from
Dec 31, 2018
Merged

doc: edit and simplify util.inspect() docs #25195

merged 1 commit into from
Dec 31, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 23, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2050/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels Dec 23, 2018
Trott
Trott reviewed Dec 23, 2018
View reviewed changes
doc/api/util.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Dec 23, 2018
View reviewed changes
doc/api/util.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Dec 23, 2018
View reviewed changes
doc/api/util.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Dec 23, 2018
View reviewed changes
doc/api/util.md Outdated Show resolved Hide resolved
@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 27, 2018

@Trott, I've updated this PR with your suggestions.

BridgeAR
BridgeAR approved these changes Dec 27, 2018
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a few suggestions.

doc/api/util.md Outdated Show resolved Hide resolved
doc/api/util.md Outdated Show resolved Hide resolved
doc/api/util.md Outdated Show resolved Hide resolved
@cjihrig
doc: edit and simplify util.inspect() docs
3c5e237 
PR-URL: nodejs#25195
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@cjihrig cjihrig merged commit 3c5e237 into nodejs:master Dec 31, 2018
@cjihrig cjihrig deleted the doc branch December 31, 2018 16:18
targos pushed a commit that referenced this pull request Jan 1, 2019
@cjihrig @targos
doc: edit and simplify util.inspect() docs
be45469 
PR-URL: #25195
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
doc: edit and simplify util.inspect() docs
5399e1b 
PR-URL: nodejs#25195
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @nodejs-github-bot @Trott @lpinca @BridgeAR