Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: simplify code #25162

Closed
wants to merge 1 commit into from
Closed

util: simplify code #25162

wants to merge 1 commit into from

Conversation

kkty
Copy link
Contributor

@kkty kkty commented Dec 21, 2018

Simplify code by using return value of Object.defineProperty directly.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@kkty
util: simplify code
2695419 
Simplify code by using return value of Object.defineProperty directly.
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Dec 21, 2018
@shisama
Copy link
Contributor

shisama commented Dec 27, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19840/

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Dec 27, 2018
@kkty @BridgeAR
util: simplify code
455bcca 
Simplify code by using return value of Object.defineProperty directly.

PR-URL: nodejs#25162
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

Landed in 455bcca.

@kkty congratulations on your first commit to Node.js! 🎉

@BridgeAR BridgeAR closed this Dec 27, 2018
targos pushed a commit that referenced this pull request Jan 1, 2019
@kkty @targos
util: simplify code
88e7386 
Simplify code by using return value of Object.defineProperty directly.

PR-URL: #25162
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@kkty @refack
util: simplify code
de8adce 
Simplify code by using return value of Object.defineProperty directly.

PR-URL: nodejs#25162
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
@kkty @BethGriggs
util: simplify code
62f0659 
Simplify code by using return value of Object.defineProperty directly.

PR-URL: #25162
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@kkty @BethGriggs
util: simplify code
6d7c2d3 
Simplify code by using return value of Object.defineProperty directly.

PR-URL: #25162
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@kkty @BethGriggs
util: simplify code
3f155bf 
Simplify code by using return value of Object.defineProperty directly.

PR-URL: #25162
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@kkty @MylesBorins
util: simplify code
5dd31bc 
Simplify code by using return value of Object.defineProperty directly.

PR-URL: #25162
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Aug 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@tniessen tniessen tniessen approved these changes

@vdeturckheim vdeturckheim vdeturckheim approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@shisama shisama shisama approved these changes

Assignees
No one assigned
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kkty @shisama @BridgeAR @jasnell @tniessen @vdeturckheim @nodejs-github-bot