Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x] update the http.request.setTimeout docs to be accurate #25123

Conversation

jbunton-atlassian
Copy link
Contributor

When upgrading from Node.js 8 to 10 I hit the behaviour change in #8895. This documentation update would have helped me find the problem faster :)

Also see #25121 for an update to the docs on master.

Thanks :)

Checklist

Original commit message:

    [cpu-profiler] Fix a leak caused by re-logging existing functions.

    Don't re-log all existing functions during StartProcessorIfNotStarted().
    They will already be in the CodeMap attached to the ProfileGenerator and
    re-logging them causes leaks. See the linked bug for more details.

    Bug: v8:8253
    Change-Id: Ibb1a1ab2431c588e8c3a3a9ff714767cdf61a88e
    Reviewed-on: https://chromium-review.googlesource.com/1256763
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56336}

Refs: v8/v8@525b396

PR-URL: nodejs#25041
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Rod Vagg <rod@vagg.org>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. v8.x labels Dec 19, 2018
doc/api/http.md Outdated Show resolved Hide resolved
@jbunton-atlassian jbunton-atlassian force-pushed the update_v8.x_docs_for_http_request_setTimeout branch from 6c16983 to 544e913 Compare December 19, 2018 07:13
@jbunton-atlassian jbunton-atlassian force-pushed the update_v8.x_docs_for_http_request_setTimeout branch 3 times, most recently from b1d62ee to 44d5c9a Compare December 19, 2018 12:48
doc/api/http.md Outdated Show resolved Hide resolved
@jbunton-atlassian jbunton-atlassian force-pushed the update_v8.x_docs_for_http_request_setTimeout branch from 44d5c9a to fc173b3 Compare December 19, 2018 21:50
MylesBorins pushed a commit that referenced this pull request Dec 21, 2018
Refs: #8895

PR-URL: #25123
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax changed the title update the http.request.setTimeout docs to be accurate [v8.x] update the http.request.setTimeout docs to be accurate Dec 21, 2018
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
Refs: #8895

PR-URL: #25123
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

landed in 3af7528

rvagg pushed a commit that referenced this pull request Feb 28, 2019
Refs: #8895

PR-URL: #25123
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants