Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: move process.binding('os') to internalBinding #25087

Closed
wants to merge 1 commit into from
Closed

os: move process.binding('os') to internalBinding #25087

wants to merge 1 commit into from

Conversation

briete
Copy link
Contributor

@briete briete commented Dec 17, 2018 •
edited
Loading

see: #22160
ref: #22292

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem. labels Dec 17, 2018
@addaleax
Copy link
Member

addaleax commented Dec 17, 2018 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19613/ ✔️

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 17, 2018
@briete briete mentioned this pull request Dec 17, 2018
Closed
2 tasks
@danbev
Copy link
Contributor

danbev commented Dec 20, 2018

Landed in 937c769. 🎉

@danbev danbev closed this Dec 20, 2018
danbev pushed a commit that referenced this pull request Dec 20, 2018
@briete @danbev
os: move process.binding('os') to internalBinding
937c769 
PR-URL: #25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request Dec 20, 2018
Closed
33 tasks
@briete briete deleted the os-internal-binding branch December 25, 2018 00:47
@MylesBorins
Copy link
Contributor

This does not land cleanly on v11.x, would someone be willing to backport?

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 9, 2019
@briete @BridgeAR
os: move process.binding('os') to internalBinding
09f844a 
PR-URL: nodejs#25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 9, 2019
Closed
4 tasks
BridgeAR pushed a commit that referenced this pull request Jan 10, 2019
@briete @BridgeAR
os: move process.binding('os') to internalBinding
55d185f 
PR-URL: #25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 11, 2019
@briete @joyeecheung
os: move process.binding('os') to internalBinding
181d03a 
PR-URL: nodejs#25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@briete @addaleax
os: move process.binding('os') to internalBinding
d197105 
PR-URL: #25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: #25446
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@briete @refack
os: move process.binding('os') to internalBinding
1f17c2c 
PR-URL: nodejs#25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@briete @BridgeAR
os: move process.binding('os') to internalBinding
1fa971f 
PR-URL: nodejs#25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@briete @BridgeAR
os: move process.binding('os') to internalBinding
f5e7157 
PR-URL: nodejs#25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: nodejs#25446
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@briete @addaleax @danbev @MylesBorins @jasnell @cjihrig @BethGriggs @BridgeAR @nodejs-github-bot