Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: split test-cli-syntax into multiple tests #24922

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 9, 2018

Split test-cli-syntax into multiple files to improve reliability and/or
isolate unreliable test cases.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 9, 2018
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 9, 2018
@Trott
Copy link
Member Author

Trott commented Dec 9, 2018

Refs: #24403

@Trott Trott removed the fast-track PRs that do not need to wait for 48 hours to land. label Dec 9, 2018
@Trott
Copy link
Member Author

Trott commented Dec 9, 2018

At least to see what happens, CI: https://ci.nodejs.org/job/node-test-pull-request/19357/

@Trott
Copy link
Member Author

Trott commented Dec 9, 2018

With this change, it's the file-not-found test that failed in CI, which is the typical part that failed in the more monolithic version of the test. But I guess we (meaning @addaleax and perhaps some other people-who-aren't-me) already knew that it wasn't failing because of side effects.

https://ci.nodejs.org/job/node-test-commit-aix/19542/nodes=aix61-ppc64/console on test-osuosl-aix61-ppc64_be-1

10:45:19 not ok 2383 sequential/test-cli-syntax-file-not-found
10:45:19   ---
10:45:19   duration_ms: 2.6
10:45:19   severity: fail
10:45:19   exitcode: 1
10:45:19   stack: |-
10:45:19     assert.js:86
10:45:19       throw new AssertionError(obj);
10:45:19       ^
10:45:19     
10:45:19     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
10:45:19     
10:45:19     null !== 1
10:45:19     
10:45:19         at common.mustCall (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/sequential/test-cli-syntax-file-not-found.js:36:14)
10:45:19         at /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/common/index.js:346:15
10:45:19         at ChildProcess.exithandler (child_process.js:301:5)
10:45:19         at ChildProcess.emit (events.js:189:13)
10:45:19         at maybeClose (internal/child_process.js:978:16)
10:45:19         at Process.ChildProcess._handle.onexit (internal/child_process.js:265:5)
10:45:19   ...

@Trott
Copy link
Member Author

Trott commented Dec 9, 2018

Oh, with this change, we can probably move some or all of these back to parallel.

@Trott
Copy link
Member Author

Trott commented Dec 10, 2018

@Trott
Copy link
Member Author

Trott commented Dec 10, 2018

On Resume Build, it was test/sequential/test-cli-syntax-bad and test/sequential/test-cli-syntax-file-not-found. I was hoping splitting it up would result in the error occurring in a more consistent way, but I guess not. It's still all over the place...

@Trott
Copy link
Member Author

Trott commented Dec 12, 2018

Rebased to remove conflict. Updated sequential.status. Moved tests that can now work in the parallel directory:

$ tools/test.py -j 96 --repeat 192 test/parallel/test-cli-syntax-*
[00:48|% 100|+ 576|-   0]: Done                              
$

@Trott
Copy link
Member Author

Trott commented Dec 12, 2018

@Trott
Copy link
Member Author

Trott commented Dec 12, 2018

@Trott
Copy link
Member Author

Trott commented Dec 12, 2018

@Trott
Copy link
Member Author

Trott commented Dec 13, 2018

@Trott
Copy link
Member Author

Trott commented Dec 13, 2018

Split test-cli-syntax into multiple files to improve reliability and/or
isolate unreliable test cases.

Move test cases back to parallel as appropriate.
@Trott
Copy link
Member Author

Trott commented Dec 13, 2018

Landed in a3801e9

@Trott Trott closed this Dec 13, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 13, 2018
Split test-cli-syntax into multiple files to improve reliability and/or
isolate unreliable test cases.

Move test cases back to parallel as appropriate.

PR-URL: nodejs#24922
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
Split test-cli-syntax into multiple files to improve reliability and/or
isolate unreliable test cases.

Move test cases back to parallel as appropriate.

PR-URL: #24922
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Split test-cli-syntax into multiple files to improve reliability and/or
isolate unreliable test cases.

Move test cases back to parallel as appropriate.

PR-URL: nodejs#24922
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
BethGriggs pushed a commit that referenced this pull request Apr 8, 2019
Split test-cli-syntax into multiple files to improve reliability and/or
isolate unreliable test cases.

Move test cases back to parallel as appropriate.

PR-URL: #24922
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
@Trott Trott deleted the divide-syntax branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants