Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: check for the correct strict equal arguments order #24752

Closed
wants to merge 1 commit into from
Closed

test: check for the correct strict equal arguments order #24752

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

This activates a eslint rule to verify that the assert.strictEqual()
arguments are in the correct order.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
test: check for the correct strict equal arguments order
642d4c4 
This activates a eslint rule to verify that the `assert.strictEqual()`
arguments are in the correct order.
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1746/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 30, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 2, 2018

@nodejs/testing @nodejs/linting PTAL

@BridgeAR BridgeAR requested a review from Trott December 2, 2018 21:46
@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 3, 2018

This needs some LGs.

This activates the eslint rule used so far for Code & Learn events to switch to the correct assertion argument order. These are now all in place and we should activate the rule to prevent further mistakes.

@gireeshpunathil
Copy link
Member

@BridgeAR - can you pls confirm the following?

  • the eslint rule on assert.strictEqual was already existing, and you are just enabling it, as we have got almost all of those in
  • the eslint rule is not foolproof, it banks on statically known assumptions on what could be expected and what could be actual
  • the other changes are the few missing (from C&L) test cases where the order is in old style, and you are fixing it in anticipation of linter fail.

pls let me know, thanks.

@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 3, 2018

@gireeshpunathil all are correct.

@addaleax
Copy link
Member

addaleax commented Dec 4, 2018

CI (scheduled): https://ci.nodejs.org/job/node-test-pull-request/19186/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 4, 2018
Trott
Trott approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if lint and CI are green. Thanks!

@Trott
Copy link
Member

Trott commented Dec 4, 2018

Landed in 9e12409

@Trott Trott closed this Dec 4, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 4, 2018
@BridgeAR @Trott
test: check for the correct strict equal arguments order
9e12409 
This activates a eslint rule to verify that the `assert.strictEqual()`
arguments are in the correct order.

PR-URL: nodejs#24752
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR added a commit that referenced this pull request Dec 5, 2018
@BridgeAR
test: check for the correct strict equal arguments order
a7a1cb4 
This activates a eslint rule to verify that the `assert.strictEqual()`
arguments are in the correct order.

PR-URL: #24752
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeAR @refack
test: check for the correct strict equal arguments order
2a53166 
This activates a eslint rule to verify that the `assert.strictEqual()`
arguments are in the correct order.

PR-URL: nodejs#24752
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR deleted the strict-equal-arguments-order branch January 20, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BridgeAR @nodejs-github-bot @gireeshpunathil @addaleax @Trott @BethGriggs