Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix worker threads can't read stdout #24652

Closed
wants to merge 1 commit into from

Conversation

leeight
Copy link
Contributor

@leeight leeight commented Nov 26, 2018

Fix: #24636

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the worker Issues and PRs related to Worker support. label Nov 26, 2018
@leeight
Copy link
Contributor Author

leeight commented Nov 26, 2018

/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:145
      if (err) throw err
               ^
Error: Invalid api format
    at new Parser (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/node_modules/gitlint-parser-base/index.js:23:15)
    at new Parser (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/node_modules/gitlint-parser-node/index.js:15:5)
    at ValidateCommit.lint (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/lib/index.js:49:22)
    at load (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:146:9)
    at IncomingMessage.res.on (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:77:9)
    at IncomingMessage.emit (events.js:187:15)
    at endReadableNT (_stream_readable.js:1098:12)
    at process.internalTickCallback (internal/process/next_tick.js:72:19)

@addaleax
Copy link
Member

@leeight Thank you! Can you explain why this fixes the issue, and add a regression test?

@richardlau
Copy link
Member

/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:145
      if (err) throw err
               ^
Error: Invalid api format
    at new Parser (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/node_modules/gitlint-parser-base/index.js:23:15)
    at new Parser (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/node_modules/gitlint-parser-node/index.js:15:5)
    at ValidateCommit.lint (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/lib/index.js:49:22)
    at load (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:146:9)
    at IncomingMessage.res.on (/home/travis/.npm/_npx/4517/lib/node_modules/core-validate-commit/bin/cmd.js:77:9)
    at IncomingMessage.emit (events.js:187:15)
    at endReadableNT (_stream_readable.js:1098:12)
    at process.internalTickCallback (internal/process/next_tick.js:72:19)

I think this is a different manifestation of hitting the GitHub API rate limit (#24567) within core-validate-commit rather than before calling it. It should be addressed by #24574 which will avoid calling the GitHub API.

@leeight
Copy link
Contributor Author

leeight commented Nov 26, 2018

@addaleax OK i'll add a testcase

@addaleax
Copy link
Member

I think this has been resolved by #24932? Either way, thank you for the PR! 👍

@addaleax addaleax closed this Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worker Threads can't read stdout
4 participants